Add repo-root input to e2e-failure-analyzer action#13671
Merged
Conversation
positron-builds checks out the positron repo as a submodule, so test/e2e source lives at $GITHUB_WORKSPACE/positron, not $GITHUB_WORKSPACE. Make the path configurable so positron-builds can point the analyzer at the right tree; default preserves Path A behavior on positron.
|
E2E Tests 🚀 |
PETE's assessment 🧪Verdict: Not applicable -- All changed files are docs, config, or lockfiles -- no source behavior to test. What changed1 file(s), categorized as: config-repo (1). PETE (Positron Extreme Test Experiment): an LLM-based test-coverage advisor, currently in pilot. Pre-filter short-circuited the LLM check on this PR. Run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is needed to get e2e-failuer-analyzer to find the right repo-root when running from positron-builds
Summary
repo-rootinput to.github/actions/e2e-failure-analyzer/action.ymland binds it to the analyze step'sREPO_ROOTenv var.${{ github.workspace }}, preserving Path A behavior on this repo.${{ github.workspace }}/positronso the analyzer reads test source from the submodule path (wheretest/e2e/actually lives in that workflow).Companion to posit-dev/positron-builds#13627.
analyze.mjsalready readsREPO_ROOTfrom env with an empty-string fallback, so no script changes are needed.